chore(deps): aws-cdk-lib を 2.254.0 に更新#40
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
依存パッケージのバージョン更新を、lockfile の整合性問題を回避する形で丁寧に切り出した良い対応です。問題の原因（@aws-cdk/cloud-assembly-api の bundleDependencies から jsonschema が外れたことによる lockfile 欠落）の特定と説明も明確で、再発防止にも役立つ内容となっています。
aws-cdk-lib を 2.253.0 から 2.254.0 へ更新し、npm ci が失敗する問題を解消するために lockfile を再生成しています。
Changes:
infra/package.jsonのaws-cdk-libを 2.254.0 に更新infra/package-lock.jsonを再生成し、jsonschemaを含む依存ツリーを正しく反映- 関連する内部依存（
@aws-cdk/cloud-assembly-api2.2.3、@aws-cdk/cloud-assembly-schema^53.21.0、fast-uri3.1.2 など）の更新
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| infra/package.json | aws-cdk-lib を 2.253.0 → 2.254.0 に更新 |
| infra/package-lock.json | aws-cdk-lib 更新に伴う lockfile 再生成（jsonschema 等の整合性修正を含む） |
Files not reviewed (1)
- infra/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue
なし
変更内容
infra/package.json:aws-cdk-lib2.253.0 → 2.254.0infra/package-lock.json: 上記に伴う再生成#38 で aws-cdk-lib 2.254.0 への更新が含まれているが、aws-cdk-lib 側で
@aws-cdk/cloud-assembly-apiのbundleDependenciesからjsonschemaが外れた (aws/aws-cdk#37774) ことで Renovate 生成 lockfile にnode_modules/aws-cdk-lib/node_modules/@aws-cdk/cloud-assembly-api/node_modules/jsonschemaが欠落し、npm ciがMissing: jsonschema@1.4.1 from lock fileで失敗する。aws-cdk-lib だけ単独で更新して lockfile を正しく再生成する。確認したこと
npm ci(root / infra) がエラーなく通るnpm run synth(CI と同じダミー env) が成功するスクリーンショット
なし
補足事項
なし
PR時のセルフチェック